[Koha-bugs] [Bug 33871] Add where parameter to sitemap.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
> (In reply to Pedro Amorim from comment #3)
> > Created attachment 153458 [details] [review] [review]
> > Bug 33871: Add try catch in case where parameter is not valid SQL
> > 
> > Hi Marcel is this try catch a good idea or irrelevant and unecessary?

On second thought I would not add it. Note that we are just writing to a file
here while reading db records. The DBIx exception is not really expected.

> > Also, shoul we keep at least 1 test for ->run() (without params) in
> > Sitemapper.t?
> > The where param in Sitemapper->run is optional, I think should still test
> > for ->run()

I will have a look.

-- 
You are receiving this mail because:
You are watching all bug changes.