[Koha-bugs] [Bug 33871] Add where parameter to sitemap.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33871

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
> > > Also, shoul we keep at least 1 test for ->run() (without params) in
> > > Sitemapper.t?
> > > The where param in Sitemapper->run is optional, I think should still test
> > > for ->run()

Strictly speaking perhaps yes. But looking at it, I think that we should be
pragmatic. We would be testing if an empty where, i.e. a Koha objects search
with empty parameters {} would return all records.
To make the test perform on a larger database without deleting all records,
would again need a mock on ->process. Probably too much complexity for a very
small gain to confirm something that we know and it is tested elsewhere too..

-- 
You are receiving this mail because:
You are watching all bug changes.