[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #17)
> (In reply to Katrin Fischer from comment #16)
> > (In reply to Marcel de Rooy from comment #15)
> > > +    my $ordersentences = C4::Context->preference("1PageOrderPDFText");
> > > 
> > > Sorry, Alex. But we should not add text blocks into preferences. We now have
> > > HTML blocks etc. to do this better and allow for translation.
> > > 
> > > Failed QA
> > 
> > To be fair: the PDF files are one language only, they aren't tanslatable and
> > you only use one at a time per global preference. And the WYSIWG editor
> > could create issues with the PDF.
> 
> Well, you can solve it in several ways. Small template file? But we should
> not add a preference imo.

A server side file won't really work for the use case. 

I am not a fan of "enhancing" the PDF templates - I think it's a dead end. But
I don't see as we haven't formally deprecated them, how it can block this and a
preference makes the most sense. You can't use TT or anything there, it's all
very custom as the text and contents are placed by the .pm in an .odt template.

-- 
You are receiving this mail because:
You are watching all bug changes.