[Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hum, I am not convinced. You are actually caching the value (not exactly,
almost) processed in Koha::Item->pickup_location but in
Koha::Biblio->validate_pickup_location.
And assume that you know that Koha::Item->pickup_location return value depends
on itype, homebranch, holdingbranch, ccode, branchcode.

What if the logic in Koha::Item->pickup_location changes and uses another
parameter?


minor:
$item->pickup_locations( { patron => $patron }
)->_resultset->get_column('branchcode')->all;

=> you should use Koha::Objects->get_column('branchcode')

-- 
You are receiving this mail because:
You are watching all bug changes.