[Koha-bugs] [Bug 31652] Add geo-search

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jul 21 01:47:01 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 153720
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153720
Bug 31652: Add geo-search

Review of attachment 153720:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31652&attachment=153720)
-----------------------------------------------------------------

::: Koha/SearchEngine/Elasticsearch/Indexer.pm
@@ +117,4 @@
>      }
>  
>      my $documents = $self->marc_records_to_documents($records);
> +

It looks like this file might not be altered beyond whitespace? Looks like the
whitespace change could be removed to simplify the overall patch.

::: Koha/SearchEngine/Elasticsearch/Search.pm
@@ +93,5 @@
>      my $elasticsearch = $self->get_elasticsearch();
> +
> +    # XXX investigate where empty query_string is coming from
> +    delete $query->{query}->{query_string} if
> +      $query->{query}->{query_string} && !%{$query->{query}->{query_string}};

Is this a pre-existing problem or introduced in this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list