[Koha-bugs] [Bug 33556] $c->validation should be avoided (part 1)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556

--- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #26)
> I remember now. We got communication issues. There are two different
> problems with the ERM-related code, that are (1) addressed but separatedly
> and (2) left out:
> 
> (1) I put the (minor) ERM changes on a separate bug so it doesn't pollute
> the other changes that are a lot and harder to rebase, because it fails
> badly and didn't allow to run 'qa' on the big one.

No, it was on this bug report, hence the confusion.

> (2) The ERM missing changes I'm referring to, are not those on that patch,
> but the fact this modules make use of `my $args = $c->validation->output` to
> be passed to the specific classes implementing the business logic for each
> case, and I didn't 100% understand how things worked (they feel a bit hacky)
> so wasn't sure about the right way to do it.

It certainly feels hacky, but I will someone to explain how to fix them
properly.
We are not manipulating usual Koha::Objects here, we are pulling data for an
external service and serve it to the Koha ERM Vue app. So we cannot use the
regular REST::Plugin::, we are trying to behave the same as the other objects
so that the app does not need to do different for those endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.