[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107172|0                           |1
        is obsolete|                            |

--- Comment #25 from David Cook <dcook at prosentient.com.au> ---
Created attachment 153824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153824&action=edit
Bug 25672: use enable_plugin_browser_upload flag to control plugin upload

This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which
controls whether or not Koha intranet users can upload Koha plugins via
their browser. Like "enable_plugins", it defaults to 0 for new installs.

This is useful when you want to provide Koha intranet users with plugins
that are pre-installed by administrators (by CLI) or restricting them
to plugins from a Github repo. See the following for more information:
Bug 23975 - Add ability to search and install plugins from GitHub
Bug 23191 - Administrators should be able to install plugins from the command
line

To test:
1) Apply the patch
2) Set <enable_plugins>1</enable_plugins> in koha-conf.xml
3) Add <enable_plugin_browser_upload>0</enable_plugin_browser_upload> in
koha-conf.xml
4) restart_all (in koha-testing-docker)
5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see
an option to upload plugins
6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says
"Plugin browser upload disabled!" and gives instructions on how to enable
browser upload
7) Install a plugin from the CLI using
koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl"
8) Note that the Uninstall option for the plugin does not appear
9) Enable Koha plugin git repos and search for "coverflow"
10) Note that you can find the plugin but you cannot install it

11) Change enable_plugin_browser_upload back to 1 and "restart_all"
12) Note that you can not upload plugins, uninstall plugins, and install
plugins from Git repos

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.