[Koha-bugs] [Bug 34339] $c->validation should be avoided (part 2)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34339

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From 33556:

(In reply to Tomás Cohen Arazi from comment #21)
> (In reply to Marcel de Rooy from comment #20)
> > Please clarify
> 
> I can't, and won't. It is an underlying problem with the modules design,
> which the author(s) should address. My feeling is it is related to this:
> 
> use Mojo::Base 'Mojolicious::Controller';
> 
> use Koha::ERM::EHoldings::Titles;


Just comparing Biblios with ERM/Agreements here:

=== REST/V1/Biblios
use Modern::Perl;
use Mojo::Base 'Mojolicious::Controller';
use Koha::Biblios;
use Koha::DateUtils;
use Koha::Ratings;
use Koha::RecordProcessor;
use C4::Biblio qw( DelBiblio AddBiblio ModBiblio );
use C4::Search qw( FindDuplicate );
use C4::Barcodes::ValueBuilder;
use C4::Context;
use Koha::Items;
use List::MoreUtils qw( any );
use MARC::Record::MiJ;
use Try::Tiny qw( catch try );

=== REST/V1/ERM/Agreements
use Modern::Perl;
use Mojo::Base 'Mojolicious::Controller';
use Koha::ERM::Agreements;
use Scalar::Util qw( blessed );
use Try::Tiny qw( catch try );

I do not really see a difference here. Can anyone help me why ERM/Agreements is
doing something different?

-- 
You are receiving this mail because:
You are watching all bug changes.