[Koha-bugs] [Bug 34357] New: Subroutine Koha::ItemType::SUPER::imageurl redefined

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jul 24 16:09:50 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34357

            Bug ID: 34357
           Summary: Subroutine Koha::ItemType::SUPER::imageurl redefined
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

This becomes visible since Bug 33745: Lazily create attribute accessor methods
in AUTOLOAD.

Note that Koha::ItemType was introduced with an unneeded SUPER reference on
commit db2a1aa0dda1c786c34c3cf239fccfcaedefd094:
+sub image_location {
+    my ( $self, $interface ) = @_;
+    return C4::Koha::getitemtypeimagelocation( $interface,
$self->SUPER::imageurl );
+}

We should just use $self->imageurl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list