[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169

--- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
>From IRC

Joubu> tcohen[m]: any news from AgustinMoyano[m] about bug 33169?               
huginn> ^C04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169
enhancement, P5 - low, ---, agustinmoyano, Pushed to master , Improve vue
breadcrumbs and left-hand menu^C
tcohen[m]> I wouldn't count on him taking on that
tcohen[m]> ashimema asked me, and I told him I haven't heard from him 
ashimema> It's bad we now how two ways of doing almost the same thing
tcohen[m]> ashimema: we have two ways because the previous wasn't removed, but
it is unused, right?
tcohen[m]> the missing piece here would be addressing Joubu's problem reports,
right?
Joubu> tcohen[m]: then who? If nobody we should revert then...
Joubu> we complexified the code bringing less flexibility...
tcohen[m]> it didn't look complex to me, and had Matt's signature
ashimema> I'm not actually sure
tcohen[m]> I can revert, but we need to make sure this is not what we are
aiming for 
ashimema> I think both are used
ashimema> maybe I'm wrong
tcohen[m]> the patch replaced the 'old ones'
tcohen[m]> cd koha-tmpl/intranet-tmpl/prog/js/vue
tcohen[m]> git grep Breadcrumb
tcohen[m]> I'd like to hear from Matthew Blenkinsop.
tcohen[m]> he saw some value on this on the other bug 
tcohen[m]> I'm not attached to it
Joubu> At least I would like to know if what I want to do is possible or if we
need more code
Joubu> I've tried several things but didn't manage with the current code, and I
don't understand the code to fix it
tcohen[m]> so you tried but didn't manage to fix it
tcohen[m]> ok
Joubu> if nobody understand it, apart from AgustinMoyano[m] that is not going
to spend more time on it, then it's hard to keep...
Joubu> ofc I've tried
tcohen[m]> if nobody understands it
tcohen[m]> it doesn't matter if he fixes it, right?
Joubu> QA step is there to make sure not only 1 person understand the code,
right? :D
tcohen[m]> the code in both is almost identical
tcohen[m]> well no
tcohen[m]> there's the 'NavigationItem' abstraction

Joubu> there is almost nothing identical between the 2 approaches               
Joubu> in "mine" there is a build_breadcrumb function for each item
Joubu> in the "new" one, there are some flag defined in the route definition
(is_navigation_item, is_end_node, etc.) then the logic is in navigation.js
Joubu> store/navigation.js
Joubu> that is where the logic is*

-- 
You are receiving this mail because:
You are watching all bug changes.