[Koha-bugs] [Bug 34417] ERM's breadcrumb (Vue) does not display the entity's name

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417

--- Comment #3 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #2)
> There are two things I would like to note here:
> 1. It does not feel correct to not invalidate the parameter when the view
> changed. We could end up with a name from the previous view. It's
> highlighted especially now, as we don't have all the routes modified.

Agreed, I'll add a line to reset it after each render

> 2. It does not feel optimal to have to modify each component. It would be
> nicer if we could have the value set in the route definition.
> For instance we could have: title: $__("Show {agreement.name}")
> Also we would not need the 'dynamic' flag and title could stay a string.
> I have no idea how this could be implemented however.


This would be preferable but I couldn't think of a way of doing this as the
routes are currently generated statically when the application loads. I've just
been re-reviewing and I wonder if we could pass a function as the title
property...? Then maybe we could emit something from within the API client
rather than each component which that function could pick up. That way the data
passing is centralised between the api client and the navigation store. I'll
have a play around and see if I can get something to work

-- 
You are receiving this mail because:
You are watching all bug changes.