[Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #40 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #37)
> +                            if ( row.patron != null ) {
>  +                                return $patron_to_html( row.patron, {
> display_cardnumber: true, url: true } );
> +                            }
> +                            else {
> +                                return _("A patron from library
> %s").format(escape_str(row.library.name));
>                             }
> 
> This is not correct, is it?
> row.library.name should be row.patron.library.name, but we don't have it.

It took me a minute, but I think I see what you're saying. "row.library.name"
would be the name of the library where the checkout occurred - not the name of
the library the patron is from. 

While it's possible that these two values could be the same, it's also possible
that they could be different.

Wouldn't it make more sense to just change the text to something like: "Patron
details suppressed", or "Unknown Patron", or even ""?

-- 
You are receiving this mail because:
You are watching all bug changes.