[Koha-bugs] [Bug 34338] Cardnumbers should be trimmed before insertion

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34338

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> It's not clear to me if we want to introduce a behaviour change here.
Please explain that will be the benefits of keeping this 'behavior'.

> > But something strange is going on here in the direct context:
> > 
> >     my $new_barcode = $newdata{'cardnumber'};
> >     Koha::Plugins->call( 'patron_barcode_transform', \$new_barcode );
> > 
> >     $newdata{'cardnumber'} = $new_barcode;
> > 
> > That is interfering with our new logic here.
> > Does not look good to me.
> 
> I don't understand what you mean, can you explain a bit more?

Plugin is called apparently based on cardnumber. But stores info in cardnumber.
Should be barcode, right?

-- 
You are receiving this mail because:
You are watching all bug changes.