[Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418

--- Comment #15 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Agustín Moyano from comment #13)
> > The last patch I pushed is to fix the link when it has parameters, for
> > example, the "/preservation/trains/:train_id" on the Show train breadcrumb
> 
> I am not sure to understand what this patch is trying to fix, could you
> provide more detail please?
> 
> Does it apply to the ERM module as well?
> 
> I have tried on the wip for the preservation module, and:
> 
> Preservation > Trains > Show train > Add item to train
> I have "Show train" with /cgi-bin/koha/preservation/trains/1
> 
> With and without this last patch.
> 
> I have adjusted the remote branch preservation_module-wip-33169

According to vue-router docs, "params are ignored if a path is provided, which
is not the case for query, as shown in the example above. Instead, you need to
provide the name of the route or manually specify the whole path with any
parameter"

That means that when we build the breadcrumb if in your routes tree you did not
specify a name, NavigationItem will render the second choice

<router-link
    v-else-if="item.path"
    :to="item.path"
    :class="{ disabled: item.disabled }"
>

Where item.path would be /preservation/trains/:train_id

I did not check that branch, but if you added names to your router (as ERM has)
this patch would have no effect

-- 
You are receiving this mail because:
You are watching all bug changes.