---
Created attachment 151896
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151896&action=edit
Bug 33748: Fix UI issue when importing records from a staged MARC file
This patch attempts to fix a UI issue on addorderiso2709.tt. It removes the
| which contains the actoin buttons MARC, Card, and Add Order and adds them
to the title line. This is so there is more space for the fieldsets.
1. Apply patch
2. Set MarcItemFieldsToOrder like this:
homebranch: 975$a
holdingbranch: 975$b
itype: 975$y
nonpublic_note: 975$x
public_note: 975$z
loc: 975$c
ccode: 975$8
notforloan: 975$7
quantity: 975$q
price: 975$g
replacementprice: 975$v
uri: 975$u
3. Stage a MARC file where the bibs have items attached
4. From acquisitions create a new basket and add 'From a staged file'.
5. Add the staged files to a basket.
6. Make sure the display looks correct.
7. Expand the data by clicking on the checkbox on the left hand side, or by
clicking 'Select all'.
8. Make sure the display looks correct.
9. Tab over to 'Item informtion' and make sure that display looks correct.
10. Shrink the screen size down to less that 992px, ensuring the display
remains correct.
Signed-off-by: Barbara Johnson
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:36:10 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 07:36:10 +0000
Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding
a credit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:36:12 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 07:36:12 +0000
Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding
a credit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151528|0 |1
is obsolete| |
Attachment #151650|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 151897
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151897&action=edit
Bug 33789: Return issue info. when adding a credit
To test:
1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a
patrons account after being marked as lost.
2. Check an item out to a patron, make sure it has a replacementprice
3. Mark the item as lost.
4. Now check the item in.
5. Go to the patrons account -> transaction tab. You should see 2 accountlines
related to the item.
6. For the account type 'Lost item' you will see issue infomation ( check out
date, due date, checkouted out from, etc )
7. For the account type 'Lost item fee refund' there is no issue information.
8. Apply patch
9. Try 2 - 6 again. This time the 'Lost item fee refund' should include issue
information.
Signed-off-by: Laura Escamilla
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:36:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 07:36:14 +0000
Subject: [Koha-bugs] [Bug 33789] Checkout information is missing when adding
a credit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33789
--- Comment #6 from Jonathan Druart ---
Created attachment 151898
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151898&action=edit
Bug 33789: Add unit test
JD amended patch: Remove biblionumber => 144
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:47:56 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 07:47:56 +0000
Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for
branchtransfers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
--- Comment #9 from Jonathan Druart ---
filter_by_current is not longer used apparently, shouldn't we remove it then?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:52:04 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 07:52:04 +0000
Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for
branchtransfers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493
--- Comment #10 from Jonathan Druart ---
Note that this is going to be reverted by bug 33568 in its current state. There
is a FIXME in Koha/REST/V1/Biblios.pm
Please help there ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:53:05 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 07:53:05 +0000
Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for
branchtransfers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493
--- Comment #11 from Jonathan Druart ---
And, don't forget to perltidy your new blocks of code!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:59:11 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 07:59:11 +0000
Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtj at kohaaloha.com
--- Comment #23 from Jonathan Druart ---
(In reply to Julian Maurice from comment #21)
> Also, since it's a developer-only tool, do we need to restrict ourselves to
> an old version ?
We could package the latest version on CPAN and have it in our repo.
Mason, would that work for you?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:29:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:29:49 +0000
Subject: [Koha-bugs] [Bug 33877] New: Fix contributors.yaml
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
Bug ID: 33877
Summary: Fix contributors.yaml
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: About
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
The about page dev section starts with:
Mason James (16.05)
Packaging manager (17.05)
Mason James (16.11)
Packaging manager (17.11)
Mason James (17.05)
Packaging manager (18.05, 18.11)
Mason James (18.05)
Packaging manager (19.05)
=> The script only expects to find a name here, not a version too. See also
maintainer role and how versions are handled there.
In this case I dont think it is really needed to still add that distinction
when we had two packaging managers in the past.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:30:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:30:21 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Fix contributors.yaml |Fix teams.yaml
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:32:47 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:32:47 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:32:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:32:49 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
--- Comment #1 from Marcel de Rooy ---
Created attachment 151899
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151899&action=edit
Bug 33877: Fix some entries in teams.yaml
Trivial edit.
Remove versions from the name of the packaging manager.
As also commented on BZ:
The script only expects to find a name here, not a version too.
See also maintainer role and how versions are handled there.
In this case I dont think it is really needed to still add that
distinction when we had two packaging managers in the past.
Test plan:
Look again at about.pl, Koha team, Koha development team.
Look at Mason James.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:33:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:33:14 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
Severity|enhancement |trivial
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:33:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:33:36 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
Status|Needs Signoff |Signed Off
--- Comment #2 from Marcel de Rooy ---
Trivial: self SO
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:49:33 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:49:33 +0000
Subject: [Koha-bugs] [Bug 33737] Add bookings to patron details
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33737
Marie changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marie.hedbom at musikverket.se
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:56:56 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:56:56 +0000
Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002
--- Comment #24 from Jonathan Druart ---
Suggestion addition for the wiki at
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy
"""
The code must be tidy using perltidy and the .perltidyrc file presents at the
root of the Koha directory.
You must run perltidy on any new perl files added.
When you add changes to existing files you should consider setting your code
editor accordingly.
For vim you can add the following line to you `.vimrc`: `vmap :!perltidy
-q`
Then switch to visual move (ctrl+v), select a block and press F8.
"""
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:57:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:57:39 +0000
Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_23_11_candidate
--- Comment #25 from Jonathan Druart ---
Please consider this as a candidate for 23.11 early pushes.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:59:14 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 08:59:14 +0000
Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no
longer exists causes table to not render
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873
--- Comment #7 from Pedro Amorim ---
Katrin, I think that change snuck in because at the time was seen as an
oversight, not something working as intended. But I think what you say makes
sense, we should consider reverting this FK behaviour. I think we should wait
to hear from Tomas and Martin about this (and whoever else who may want to chip
in).
However, this talk is to be had either on bug 22440 or bug 21983.
This bug (33873) is a fix for the handling of data coming from the API endpoint
that is feeding ILL requests data to the new ILL table.
This fix (33873) should be pushed, imo, regardless of if we revert the FK
relationship or not.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:39:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:39:59 +0000
Subject: [Koha-bugs] [Bug 33878] New: SIP does not warn for patron expiry
(as NotifyBorrowerDeparture does)
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33878
Bug ID: 33878
Summary: SIP does not warn for patron expiry (as
NotifyBorrowerDeparture does)
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: SIP2
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
See bug 33522 and 28688 too.
Pref NotifyBorrowerDeparture brings a warning on OPAC and staff. But SIP does
not show it if I am not mistaken.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:40:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:40:13 +0000
Subject: [Koha-bugs] [Bug 33878] SIP does not warn for patron expiry (as
NotifyBorrowerDeparture does)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33878
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:48:56 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:48:56 +0000
Subject: [Koha-bugs] [Bug 33878] SIP does not warn for patron expiry (as
NotifyBorrowerDeparture does)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33878
--- Comment #1 from Marcel de Rooy ---
On which moments should SIP warn about it? Return a book and issue one?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:53:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:53:36 +0000
Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when
sending membership expiry notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522
--- Comment #3 from Marcel de Rooy ---
Note: bug 28688 will be based on top of this one.
And will handle the case where a patron might become inactive in the time
between notification moment and expiry date.
If he is active at notification and if you would skip him, but becomes
inactive, than he would have no notice but would not be renewed. We need an
additional flag to view those patrons as inactive already at notify time.
The other way around could be a bit harder. He was not active but becomes
active again just before expiry. If you would auto renew, no problem. If you
sent a notice to inactive ones, no problem too. So only if you skipped inactive
ones, he may silently expire without a notice.
Note that we also have the NotifyBorrowerDeparture warn. Since he became active
again, he might have seen that one. It seems that SIP does not warn you for
expiry though. Opened bug 33878 for that.
If you send two expiry notices (we send a second one 7 days before), the risk
of this case is even smaller.
For now, I would consider this a side-effect of deciding to not inform inactive
users about expiry given the other possible warning. And document it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:54:10 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:54:10 +0000
Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when
sending membership expiry notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=33878
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:54:10 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:54:10 +0000
Subject: [Koha-bugs] [Bug 33878] SIP does not warn for patron expiry (as
NotifyBorrowerDeparture does)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33878
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=33522
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:57:25 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:57:25 +0000
Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership for
active patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |33522
See Also|https://bugs.koha-community |
|.org/bugzilla3/show_bug.cgi |
|?id=33522 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522
[Bug 33522] Optionally skip (in)active patrons when sending membership expiry
notices
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:57:25 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:57:25 +0000
Subject: [Koha-bugs] [Bug 33522] Optionally skip (in)active patrons when
sending membership expiry notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28688
See Also|https://bugs.koha-community |
|.org/bugzilla3/show_bug.cgi |
|?id=28688 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688
[Bug 28688] Automatically renew patron membership for active patrons
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 11:58:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 09:58:21 +0000
Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership for
active patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
Status|NEW |ASSIGNED
--- Comment #7 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #6)
> Note that bug 33522 provides another perspective: do not send expiry notices
> to inactive patrons. Might feel a bit less friendly, but could be an option
> too.
Decided to put this one on top of 33522.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:04:33 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:04:33 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146529|0 |1
is obsolete| |
--- Comment #167 from Julian Maurice ---
Created attachment 151900
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151900&action=edit
Bug 17499: Add Koha-objects for messaging preferences
This patch adds Koha-objects for messaging preferences.
Adds simple validation for messaging preferences.
The validation includes
- throw exception if both borrowernumber or categorycode is given for a new
pref
- throw exception if patron for the given borrowernumber is not found
- throw exception if category for the given categorycode is not found
- throw exception if days in advance cannot be configured but is given
- throw exception if days in advance configuration is invalid (value between
0-30)
- throw exception if digest is not available but attempted to set on
- throw exception if digest must be enabled but attempted to set off
- throw exception on duplicate messaging preference
Adds a method for getting available messaging options.
Adds a method for setting default messaging preferenes.
$patron->set_default_messaging_preferences (where $patron is a Koha::Patron)
...or...
Koha::Patron::Message::Preference->new_from_default({
borrowernumber => 123,
categorycode => "ABC",
message_attribute_id => 1,
});
Since messaging preference is a feature that has multiple related database
tables,
usage via Koha-objects is sometimes frustrating. This patch adds easy access to
message transport types via
$preference->message_transport_types (for
getting)
$preference->set({ message_transport_types => ['email', 'sms'] }) (for
setting)
(also supports other calling conventions, see documentation for more)
Adds optional parameter message_name for
Koha::Patron::Message::Preferences->find
and ->search. Simplifies the Koha-object usage by allowing developer to skip
joins
and / or querying the message name via attribute_id from message_attributes
table.
Includes test coverage for basic usage.
To test:
1. prove t/db_dependent/Koha/Patron/Message/*
Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging
with these new Koha-objects.
Signed-off-by: Dominic Pichette
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:04:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:04:38 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146530|0 |1
is obsolete| |
--- Comment #168 from Julian Maurice ---
Created attachment 151901
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151901&action=edit
Bug 17499: Define koha_object(s)_class where needed
This patch adds koha_object(s)_class for needed modules
to fix issues with tests.
Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:04:42 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:04:42 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146531|0 |1
is obsolete| |
--- Comment #169 from Julian Maurice ---
Created attachment 151902
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151902&action=edit
Bug 17499: Replace test subroutines with build_object
This patch replaces subroutines used to build test
objects with call to $builder->build_object.
To test prove that tests are still running with:
prove t/db_dependent/Koha/Patron/Message/*
Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:04:47 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:04:47 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146532|0 |1
is obsolete| |
--- Comment #170 from Julian Maurice ---
Created attachment 151903
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151903&action=edit
Bug 17499: (QA follow-up) Fix Licence Statements
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:04:53 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:04:53 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146533|0 |1
is obsolete| |
--- Comment #171 from Julian Maurice ---
Created attachment 151904
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151904&action=edit
Bug 17499: (QA follow-up) Fix POD errors
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:04:57 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:04:57 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146534|0 |1
is obsolete| |
--- Comment #172 from Julian Maurice ---
Created attachment 151905
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151905&action=edit
Bug 17499: (follow-up) More explicit exceptions
Adds and throws more detailed exceptions.
This is useful for APIs and generating translatable errors in GUI.
In short, replaces Koha::Exceptions::BadParameter with:
Koha::Exceptions::Patron::NotFound
Koha::Exceptions::Patron::Category
Koha::Exceptions::Patron::Category::NotFound
Koha::Exceptions::Patron::Message::Preference
Koha::Exceptions::Patron::Message::Preference::AttributeNotFound
Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceOutOfRange
Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceNotAvailable
Koha::Exceptions::Patron::Message::Preference::DigestNotAvailable
Koha::Exceptions::Patron::Message::Preference::DigestRequired
Koha::Exceptions::Patron::Message::Preference::EmailAddressRequired
Koha::Exceptions::Patron::Message::Preference::NoTransportType
Koha::Exceptions::Patron::Message::Preference::SMSNumberRequired
To test:
1. prove t/db_dependent/Koha/Patron/Message/Preferences.t
Sponsored-by: The National Library of Finland
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:05:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:05:02 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146535|0 |1
is obsolete| |
--- Comment #173 from Julian Maurice ---
Created attachment 151906
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151906&action=edit
Bug 17499: (follow-up) Fix warning
Fix warning
DBIx::Class::Storage::DBI::select_single(): Query returned more than one row.
SQL that returns multiple rows is DEPRECATED for ->find and ->single.
Sponsored-by: The National Library of Finland
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:05:06 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:05:06 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146536|0 |1
is obsolete| |
--- Comment #174 from Julian Maurice ---
Created attachment 151907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151907&action=edit
Bug 17499: (follow-up) Validate phone and itiva transport types
Message transport types 'phone' and 'itiva' were not validated unlike
'email' and 'sms'. This patch adds equivalent checks to the missing mtts.
To test:
1. prove t/db_dependent/Koha/Patron/Message/Preferences.t
Sponsored-by: The National Library of Finland
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:05:11 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:05:11 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146537|0 |1
is obsolete| |
--- Comment #175 from Julian Maurice ---
Created attachment 151908
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151908&action=edit
Bug 17499: (follow-up) Contact information vs. mtt validation
This patch adds a subroutine that handles message transport type validation by
first checking related patron contact information.
As an example, if there is no email address, we shouldn't let email be selected
as a messaging transport type.
The reason to isolate logic into a separate subroutine is that C4/Reserves.pm
_koha_notify_reserve() also uses the same logic and we should not duplicate it.
C4::Reserves::_koha_notify_reserve() will be adjusted to use this new sub in
Bug 18595.
To test:
1. prove t/db_dependent/Koha/Patron/Message/Preferences.t
Sponsored-by: The National Library of Finland
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:05:16 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:05:16 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146538|0 |1
is obsolete| |
--- Comment #176 from Julian Maurice ---
Created attachment 151909
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151909&action=edit
Bug 17499: (follow-up) Rename to Koha::Patron::MessagePreference
Koha::Patron::Message refers to "messages" table that is used for circulation
messages. MessagePreference now refers to a messaging preference that is used
for enqueued notifications.
To test:
1. prove t/db_dependent/Koha/Patron/MessagePreference/Attributes.t
2. prove t/db_dependent/Koha/Patron/MessagePreference/Transport/Preferences.t
3. prove t/db_dependent/Koha/Patron/MessagePreference/Transport/Types.t
4. prove t/db_dependent/Koha/Patron/MessagePreference/Transports.t
5. prove t/db_dependent/Koha/Patron/MessagePreferences.t
Sponsored-by: The National Library of Finland
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:05:20 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:05:20 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146539|0 |1
is obsolete| |
--- Comment #177 from Julian Maurice ---
Created attachment 151910
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151910&action=edit
Bug 17499: (follow-up) Add $patron->messaging_preferences accessor
To test:
1. prove t/db_dependent/Koha/Patron.t
Sponsored-by: The National Library of Finland
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:05:24 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:05:24 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #146540|0 |1
is obsolete| |
--- Comment #178 from Julian Maurice ---
Created attachment 151911
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151911&action=edit
Bug 17499: Replace Koha::MessageAttribute(s) with
Koha::Patron::MessagePreference::Attribute(s)
To test:
1. prove t/db_dependent/Illrequests.t
2. grep -rn 'Koha::MessageAttribute', observe no results in Koha code
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:05:58 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:05:58 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #179 from Julian Maurice ---
Patches rebased on master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:35:07 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:35:07 +0000
Subject: [Koha-bugs] [Bug 17505] Add routes for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65326|0 |1
is obsolete| |
--- Comment #23 from Julian Maurice ---
Created attachment 151912
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151912&action=edit
Bug 17505: REST API route for messaging preferences
Get patron's / category's messaging preferences:
GET /messaging_preferences?borrowernumber=123
- allowed if getting own preferences
- otherwise borrowers flag required
GET /messaging_preferences?categorycode=K
- borrowers flag required
Modify patron's / category's messaging preferences:
PUT /messaging_preferences?borrowernumber=123
- allowed if modifying own preferences
- otherwise borrowers flag required
PUT /messaging_preferences?categorycode=K
- borrowers flag required
Returns the following JSON object (same for PUT except for readOnly values):
{
"Advanced_Notice": {
"days_in_advance": {
"configurable": true,
"value": 20
},
"digest": {
"configurable": true,
"value": true
},
"transport_types": {
"email": true,
"sms": false
}
},
"Another_Message_Name": {
"days_in_advance": {
"configurable": false,
"value": null
},
"digest": { ...
},
...
}
To test:
1. prove t/db_dependent/api/v1/messagingpreferences.t
2. Send GET and PUT requests to /api/v1/messaging_preferences
Signed-off-by: Jiri Kozlovsky
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:37:01 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 10:37:01 +0000
Subject: [Koha-bugs] [Bug 17505] Add routes for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |julian.maurice at biblibre.com
--- Comment #24 from Julian Maurice ---
Patch rebased on master.
What is needed to make this patch move forward ? A vote on the RFC ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 13:27:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 11:27:00 +0000
Subject: [Koha-bugs] [Bug 33798] Vendor details - improve consistency of
edit forms and display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798
--- Comment #4 from Owen Leonard ---
(In reply to Jonathan Druart from comment #3)
> Owen, can I get your opinion on the second patch please?
Looks like a good improvement to me!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 13:34:28 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 11:34:28 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #25 from Marcel de Rooy ---
(In reply to Owen Leonard from comment #24)
> The interface may be assumed to be "intranet" but should it log that
> information anyway for consistency?
>
> +---------------------+--------+--------+------------+-----------+
> | datetime | branch | value | type | interface |
> +---------------------+--------+--------+------------+-----------+
> | 2023-05-30 17:16:18 | CPL | 0.0000 | issue | intranet |
> | 2023-05-30 17:16:27 | CPL | NULL | item_lost | NULL |
> | 2023-05-30 17:18:45 | CPL | NULL | item_found | NULL |
> | 2023-05-30 17:18:45 | CPL | NULL | return | intranet |
> +---------------------+--------+--------+------------+-----------+
Good point.
This was actually developed before the interface column was added. But I
suppose that it should default to context->interface.
Adding a follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 13:36:03 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 11:36:03 +0000
Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928
--- Comment #33 from Marcel de Rooy ---
Will add a follow-up for this development on 33608. It would be good to default
to C4::Context->interface instead of NULL, or always needing to pass it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 13:44:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 11:44:48 +0000
Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron
details and circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528
--- Comment #6 from Owen Leonard ---
(In reply to Sam Lau from comment #5)
> I ran into some problems testing the club tab in both the check out page and
> the details page.
I am not seeing this in my test system. Could you try again? Are there any
JavaScript errors in the console?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:01:23 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:01:23 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
--- Comment #26 from Marcel de Rooy ---
Catching a C4::Auth problem on the way:
This line in cookie_auth may bite us (and possibly many other callers):
C4::Context->interface($session->param('interface'));
It overwrites the interface set by get_template_and_user. Here from additem.
Here i am on intranet but i logged in via opac
| 2023-06-01 11:44:01 | CPL | NULL | item_lost | | 1 | BKS
| NULL | NULL | NULL | NULL | opac |
Here again on intranet with intranet cookie:
| 2023-06-01 11:58:11 | CPL | NULL | item_found | | 1 | BKS
| NULL | NULL | NULL | NULL | intranet |
Will open another report for this small Auth 'bug'.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:10:27 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:10:27 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #27 from Marcel de Rooy ---
Created attachment 151913
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151913&action=edit
Bug 33608: (follow-up) Default value for interface column
We should default to C4::Context->interface.
Test plan:
Login via intranet (see Bugzilla report).
Edit an item. Set to lost.
Check entry in statistics table on interface value.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:11:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:11:29 +0000
Subject: [Koha-bugs] [Bug 33879] New: Cookie_auth overwrites interface set
by get_template_and_user
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Bug ID: 33879
Summary: Cookie_auth overwrites interface set by
get_template_and_user
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Authentication
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
CC: dpavlin at rot13.org
>From bug 33608
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:12:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:12:59 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=33879
--- Comment #28 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #26)
> Will open another report for this small Auth 'bug'.
Opened byg 33879
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:12:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:12:59 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=33608
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:15:26 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:15:26 +0000
Subject: [Koha-bugs] [Bug 33865] JS error when importing a staged MARC
record file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33865
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:15:28 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:15:28 +0000
Subject: [Koha-bugs] [Bug 33865] JS error when importing a staged MARC
record file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33865
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151892|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 151914
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151914&action=edit
Bug 33865: (bug 27421 follow-up) Remove leftover
Bug 27421 replaced the progress bar with job_progress.inc.
The code related to the old progress bar has not been removed however.
Moreover there was a JS error in the console:
"Uncaught ReferenceError: submitBackgroundJob is not defined"
Test plan:
Stage a MARC record for import
Import it
Revert the import
All should work correctly, without JS error in the console and with the
progress bar displayed nicely during the staging step.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:23:36 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:23:36 +0000
Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the
biblio detail view
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568
--- Comment #18 from Nick Clemens ---
* Filters are operating on codes not values, 'FPL' works in 'Home library' but
'Fairview' doesn't
* Location appears in 'Home library' column, but cannot be filtered on code or
value
* Status column not filterable or sortable
* Date columns filters only work on SQL formats '2023-06-01' works '06/01/2023'
doesn't
* Click 'show filters', 'hide filters' and repeat X 2 - status column
disappears?
If you do choose to show all items, a sort action requires reloading the whole
table - is it possible to sort/filter on the loaded data?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:38 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:41 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:41 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151051|0 |1
is obsolete| |
Attachment #151052|0 |1
is obsolete| |
Attachment #151053|0 |1
is obsolete| |
Attachment #151054|0 |1
is obsolete| |
Attachment #151055|0 |1
is obsolete| |
Attachment #151056|0 |1
is obsolete| |
Attachment #151057|0 |1
is obsolete| |
Attachment #151913|0 |1
is obsolete| |
--- Comment #29 from Owen Leonard ---
Created attachment 151915
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151915&action=edit
Bug 33608: Add two new circulation types in Statistics module
These are: item_lost and item_found. Speak for themself.
Test plan:
Run t/db_dependent/Stats.t
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:43 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #30 from Owen Leonard ---
Created attachment 151916
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151916&action=edit
Bug 33608: Add UpdateStats to item->store
Test plan:
Run t/db_dependent/Koha/Item.t
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:46 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:46 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #31 from Owen Leonard ---
Created attachment 151917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151917&action=edit
Bug 33608: Rearranging Stats.t, removing useless t version
Subtest, modules, license.
The t/Stats.t is as good as empty, can be removed.
Test plan:
Run t/db_dependent/Stats.t
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:48 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #32 from Owen Leonard ---
Created attachment 151918
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151918&action=edit
Bug 33608: Correct indentation in Stats.t
Test plan:
Run t/db_dependent/Stats.t
Run git diff -w HEAD~1.. t/db_dependent/Stats.t, proving that we
only did whitespace changes.
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:51 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:51 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #33 from Owen Leonard ---
Created attachment 151919
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151919&action=edit
Bug 33608: Redirect UpdateStats to Koha namespace
Moving code to Koha::Statistic->new and ->insert.
Polishing code a bit further in next patch.
Test plan:
Run t/db_dependent/Stats.t
Run t/db_dependent/Koha/Statistics.t
Run t/db_dependent/Koha/Pseudonymization.t
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:53 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:53 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #34 from Owen Leonard ---
Created attachment 151920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151920&action=edit
Bug 33608: Polish Koha::Statistic further
Adding exceptions, removing croaks.
No exception in new for unknown hash keys, store will catch that.
Prepare switching amount parameter to value (db column name).
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:56 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:56 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #35 from Owen Leonard ---
Created attachment 151921
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151921&action=edit
Bug 33608: Move older Stats tests to Koha/Statistics.t
Test plan:
Run t/db_dependent/Koha/Statistics.t
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:24:59 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:24:59 +0000
Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about
found/recovered books
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608
--- Comment #36 from Owen Leonard ---
Created attachment 151922
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151922&action=edit
Bug 33608: (follow-up) Default value for interface column
We should default to C4::Context->interface.
Test plan:
Login via intranet (see Bugzilla report).
Edit an item. Set to lost.
Check entry in statistics table on interface value.
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:26:09 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:26:09 +0000
Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for
branchtransfers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493
--- Comment #12 from Nick Clemens ---
(In reply to Jonathan Druart from comment #10)
> Note that this is going to be reverted by bug 33568 in its current state.
> There is a FIXME in Koha/REST/V1/Biblios.pm
>
> Please help there ;)
33493 is in your commit history on the branch - you use a new function
'transfer' which simply calls 'get_transfer' so will use the new relationship
there if you apply latest version
The 'FIXME' just suggests adding the prefetch - so just yes, do that using this
relationship
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:26:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:26:38 +0000
Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to
server side filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
--- Comment #20 from Jonathan Druart ---
>From https://tree.taiga.io/project/koha-ils/task/117
And IRC:
Joubu> tcohen: see https://tree.taiga.io/project/koha-ils/task/117
Joubu> tcohen: installer/data/mysql/db_revs/221200026.pl
Joubu> it must be *unless* fk exists!
Joubu> there is also a typo in the description endopoint
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:27:37 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:27:37 +0000
Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for
branchtransfers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #149469|0 |1
is obsolete| |
--- Comment #13 from Nick Clemens ---
Created attachment 151923
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151923&action=edit
Bug 33493: Add a filter relationship for branchtransfers
Prefetching is useful, but we don't want to fetch all the inactive
transfers for an item. This patch adds a filtered relationship and
updates get_transfer(s) to use this
To test:
prove -v t/db_dependent/Koha/Item.t
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:27:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:27:39 +0000
Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for
branchtransfers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151865|0 |1
is obsolete| |
--- Comment #14 from Nick Clemens ---
Created attachment 151924
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151924&action=edit
Bug 33493: (follow-up) Rename relationship and add test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:46:11 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:46:11 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:49:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:49:55 +0000
Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the
same guarantor when calculating against NoIssuesChargeGuarantees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #14 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #13)
> # Failed test 'NoIssuesChargeGuarantees tests'
> # at t/db_dependent/SIP/Patron.t line 338.
Did you restart_all to make sure SIP is adjusted? All tests pass for me
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:52:26 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:52:26 +0000
Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more
descriptive links
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:52:28 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:52:28 +0000
Subject: [Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more
descriptive links
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809
--- Comment #6 from Owen Leonard ---
Created attachment 151925
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151925&action=edit
Bug 33809: (follow-up) Grammar correction
This is somewhat nitpicky but I think "Show fewer..." is more correct
than "Show less..." for strings like "Show fewer authors."
'Generally, fewer is used when the number of things is counted ("fewer
problems") whereas less is used when the number is measured ("less
trouble" or "less time").'
-- https://www.merriam-webster.com/words-at-play/fewer-vs-less
It's not a strict rule but to my ear it sounds more correct. The brief
"Show less" displayed on screen seems fine because the object feels
indeterminate: "Show less information."
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:52:34 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:52:34 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
--- Comment #1 from Marcel de Rooy ---
Use case
If you logged in via OPAC (sharing same domain with intranet), and then switch
to staff side, get_template_and_user gets the correct interface from the staff
script but later on checkauth is called and then check_cookie_auth. The last
one may override the interface with the interface from the cookie (opac in our
example).
This is confusing.
What would be the side-effects if we decide not to overwrite there but only
fill if we have nothing?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:55:24 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:55:24 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:55:40 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:55:40 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:55:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 12:55:43 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
--- Comment #6 from Mason James ---
Created attachment 151926
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151926&action=edit
Bug 33371: Add [Install] section to koha-common.service
to test:
1/ install pkg, reboot, note service is not started
2/ add patch, build package
3/ install pkg, reboot, note service is started! :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:08:46 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:08:46 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151926|0 |1
is obsolete| |
--- Comment #7 from Mason James ---
Created attachment 151927
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151927&action=edit
Bug 33371: Add [Install] section to koha-common.service
to test:
1/ install pkg, reboot, note service is not 'active'
2/ add patch, build package
3/ install pkg, reboot, note service is 'active' :)
root at deb11:/etc# systemctl status koha-common
* koha-common.service - Start required services for each Koha instance
Loaded: loaded (/etc/init.d/koha-common; enabled; vendor preset: enabled)
<<<<
Active: active (exited) since Thu 2023-06-01 12:45:08 UTC; 13min ago
Tasks: 0 (limit: 2244)
Memory: 0B
CPU: 0
CGroup: /system.slice/koha-common.service
Jun 01 12:45:08 deb11 systemd[1]: Starting Start required services for each
Koha instance...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:14:10 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:14:10 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:14:12 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:14:12 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
--- Comment #2 from Marcel de Rooy ---
Created attachment 151928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151928&action=edit
Bug 33879: Do no longer overwrite interface in cookie_auth
This will only have effect on installations running OPAC and staff
on the same domain name. In that case an OPAC cookie still allows
you to access intranet, and v.v.
Test plan:
Repeat the following steps WITHOUT this patch and WITH it.
Login via OPAC.
Go to staff. Perform an action that logs the interface in e.g. the
statistics table, like a checkout.
Inspect interface in the corresponding table. Observe difference
that this patch makes.
With this patch:
Run t/db_dependent/Auth.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:14:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:14:39 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
--- Comment #3 from Marcel de Rooy ---
Still looking at unit test.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:14:44 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:14:44 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:14:50 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:14:50 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:30:34 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:30:34 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
Andrew Nugged changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:30:37 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:30:37 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
Andrew Nugged changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151927|0 |1
is obsolete| |
--- Comment #8 from Andrew Nugged ---
Created attachment 151929
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151929&action=edit
[PATCH] Bug 33371: Add [Install] section to koha-common.service
to test:
1/ install pkg, reboot, note service is not 'active'
2/ add patch, build package
3/ install pkg, reboot, note service is 'active' :)
root at deb11:/etc# systemctl status koha-common
* koha-common.service - Start required services for each Koha instance
Loaded: loaded (/etc/init.d/koha-common; enabled; vendor preset: enabled)
<<<<
Active: active (exited) since Thu 2023-06-01 12:45:08 UTC; 13min ago
Tasks: 0 (limit: 2244)
Memory: 0B
CPU: 0
CGroup: /system.slice/koha-common.service
Jun 01 12:45:08 deb11 systemd[1]: Starting Start required services for each
Koha instance...
Signed-off-by: Andrew Nugged
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:32:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:32:02 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
Andrew Nugged changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151929|0 |1
is obsolete| |
--- Comment #9 from Andrew Nugged ---
Created attachment 151930
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151930&action=edit
Bug 33371: Add [Install] section to koha-common.service
to test:
1/ install pkg, reboot, note service is not 'active'
2/ add patch, build package
3/ install pkg, reboot, note service is 'active' :)
root at deb11:/etc# systemctl status koha-common
* koha-common.service - Start required services for each Koha instance
Loaded: loaded (/etc/init.d/koha-common; enabled; vendor preset: enabled)
<<<<
Active: active (exited) since Thu 2023-06-01 12:45:08 UTC; 13min ago
Tasks: 0 (limit: 2244)
Memory: 0B
CPU: 0
CGroup: /system.slice/koha-common.service
Jun 01 12:45:08 deb11 systemd[1]: Starting Start required services for each
Koha instance...
Signed-off-by: Andrew Nugged
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:51:58 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:51:58 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:52:00 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:52:00 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
--- Comment #4 from Marcel de Rooy ---
Created attachment 151931
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151931&action=edit
Bug 33879: Add unit test to show problem
Test plan:
Run t/db_dependent/Auth.t without second patch.
Should fail:
# got: 'opac'
# expected: 'intranet'
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:52:03 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:52:03 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151928|0 |1
is obsolete| |
--- Comment #5 from Marcel de Rooy ---
Created attachment 151932
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151932&action=edit
Bug 33879: Do no longer overwrite interface in cookie_auth
This will only have effect on installations running OPAC and staff
on the same domain name. In that case an OPAC cookie still allows
you to access intranet, and v.v.
Test plan:
Repeat the following steps WITHOUT this patch and WITH it.
Login via OPAC.
Go to staff. Perform an action that logs the interface in e.g. the
statistics table, like a checkout.
Inspect interface in the corresponding table. Observe difference
that this patch makes.
With this patch:
Run t/db_dependent/Auth.t. Should pass again.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:52:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:52:29 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
--- Comment #6 from Marcel de Rooy ---
Created attachment 151933
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151933&action=edit
Bug 33879: Do no longer overwrite interface in check_cookie_auth
This will only have effect on installations running OPAC and staff
on the same domain name. In that case an OPAC cookie still allows
you to access intranet, and v.v.
Test plan:
Repeat the following steps WITHOUT this patch and WITH it.
Login via OPAC.
Go to staff. Perform an action that logs the interface in e.g. the
statistics table, like a checkout.
Inspect interface in the corresponding table. Observe difference
that this patch makes.
With this patch:
Run t/db_dependent/Auth.t. Should pass again.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:52:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:52:55 +0000
Subject: [Koha-bugs] [Bug 33879] Cookie_auth overwrites interface set by
get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151932|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:56:23 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 13:56:23 +0000
Subject: [Koha-bugs] [Bug 33879] Check_cookie_auth overwrites interface set
by get_template_and_user
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33879
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Cookie_auth overwrites |Check_cookie_auth
|interface set by |overwrites interface set by
|get_template_and_user |get_template_and_user
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:12:21 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:12:21 +0000
Subject: [Koha-bugs] [Bug 33865] JS error when importing a staged MARC
record file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33865
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:12:24 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:12:24 +0000
Subject: [Koha-bugs] [Bug 33865] JS error when importing a staged MARC
record file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33865
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151914|0 |1
is obsolete| |
--- Comment #3 from Marcel de Rooy ---
Created attachment 151934
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151934&action=edit
Bug 33865: (bug 27421 follow-up) Remove leftover
Bug 27421 replaced the progress bar with job_progress.inc.
The code related to the old progress bar has not been removed however.
Moreover there was a JS error in the console:
"Uncaught ReferenceError: submitBackgroundJob is not defined"
Test plan:
Stage a MARC record for import
Import it
Revert the import
All should work correctly, without JS error in the console and with the
progress bar displayed nicely during the staging step.
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:12:33 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:12:33 +0000
Subject: [Koha-bugs] [Bug 33865] JS error when importing a staged MARC
record file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33865
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
CC| |m.de.rooy at rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:16:12 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:16:12 +0000
Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the
same guarantor when calculating against NoIssuesChargeGuarantees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411
--- Comment #15 from Marcel de Rooy ---
# Subtest: NoIssuesChargeGuarantees tests
1..6
ok 1 - Only patron's fines are reported in total
ok 2 - Guarantor blocked
not ok 3 - Screen message includes related fines total
# Failed test 'Screen message includes related fines total'
# at t/db_dependent/SIP/Patron.t line 331.
# 'Greetings from Koha. Og_K_qe88A -- Patron blocked by
fines (11.11) on guaranteed accounts -- Patron owes 11.00'
# doesn't match '(?^u:Patron blocked by fines \(22\.22\) on guaranteed
accounts)'
ok 4 - Guarantee only fines correctly counted
ok 5 - Guarantee not blocked by guarantor fines
ok 6 - Screen message does not include blocked message
# Looks like you failed 1 test of 6.
not ok 9 - NoIssuesChargeGuarantees tests
There is a difference. Only one test failed now. So progress :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:30:55 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:30:55 +0000
Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the
same guarantor when calculating against NoIssuesChargeGuarantees
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411
--- Comment #16 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #15)
> # Failed test 'Screen message includes related fines total'
> # at t/db_dependent/SIP/Patron.t line 331.
> # 'Greetings from Koha. Og_K_qe88A -- Patron blocked
> by fines (11.11) on guaranteed accounts -- Patron owes 11.00'
> # doesn't match '(?^u:Patron blocked by fines \(22\.22\) on
> guaranteed accounts)'
If I debug on $patron->account->lines, I only see that 11 euro.
Do you miss a few assumptions in the mocking or so still?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:44:57 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:44:57 +0000
Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron
details and circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--- Comment #7 from Lucas Gass ---
(In reply to Owen Leonard from comment #6)
> (In reply to Sam Lau from comment #5)
> > I ran into some problems testing the club tab in both the check out page and
> > the details page.
>
> I am not seeing this in my test system. Could you try again? Are there any
> JavaScript errors in the console?
I also recreate this. Steps I used:
1. Apply patch
2. Go to patron checkout or detail tab
3. Click on Clubs tab > Enroll
4. Above the table click 'Finish enrollment' or 'Cancel'
5. Clubs panel now appears in unusual position.
6. Click on another tab (Checkouts, Holds ) and the Clubs panel now has a green
background.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:45:38 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:45:38 +0000
Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron
details and circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528
--- Comment #8 from Lucas Gass ---
Created attachment 151935
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151935&action=edit
Screenshot of display
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:47:20 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:47:20 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
--- Comment #3 from Tomás Cohen Arazi ---
Created attachment 151936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151936&action=edit
Bug 33877: Add missing team members
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:52:43 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:52:43 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:53:29 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:53:29 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |23.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:53:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:53:31 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
--- Comment #4 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:54:31 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:54:31 +0000
Subject: [Koha-bugs] [Bug 33528] Use template wrapper for tabs: Patron
details and circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528
--- Comment #9 from Sam Lau ---
Here is a video of the bug as well: https://www.youtube.com/watch?v=bcNWwtvDuVc
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:54:35 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:54:35 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:55:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:55:02 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|23.05.00 |23.11.00,23.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:55:04 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:55:04 +0000
Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371
--- Comment #10 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:59:46 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 14:59:46 +0000
Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to
server side filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
--- Comment #21 from Tomás Cohen Arazi ---
Fixed in 23.05 and 23.11. Please backport the fix for 22.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:01:49 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:01:49 +0000
Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|23.11.00 |23.11.00,23.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:10:02 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:10:02 +0000
Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to
server side filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
--- Comment #22 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #19)
> Hm, I am not so happy about the FK change hidden/sneaked in with this bug.
> Especially since it's now without documentation/warning to users and can
> create data loss.
>
> If you don't store all information also in ILL request attributes it will be
> hard to determine what has been ordered for making acq decisions and
> creating reports.
>
> Also: there already was as specific bug for this change, stuck in discussion
> for these reasons: bug 21983
I'd have loved to at least get a comment/reaction. The fix mentioned seems to
be to enforce the change I marked as critical.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:15:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:15:13 +0000
Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to
server side filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
--- Comment #23 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #22)
> (In reply to Katrin Fischer from comment #19)
> > Hm, I am not so happy about the FK change hidden/sneaked in with this bug.
> > Especially since it's now without documentation/warning to users and can
> > create data loss.
> >
> > If you don't store all information also in ILL request attributes it will be
> > hard to determine what has been ordered for making acq decisions and
> > creating reports.
> >
> > Also: there already was as specific bug for this change, stuck in discussion
> > for these reasons: bug 21983
>
> I'd have loved to at least get a comment/reaction. The fix mentioned seems
> to be to enforce the change I marked as critical.
Also, if you really want to do this, because it needs to be done: what's with
the old ill_requests? It caused bug 33873.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:15:40 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:15:40 +0000
Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to
server side filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
--- Comment #24 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #23)
> (In reply to Katrin Fischer from comment #22)
> > (In reply to Katrin Fischer from comment #19)
> > > Hm, I am not so happy about the FK change hidden/sneaked in with this bug.
> > > Especially since it's now without documentation/warning to users and can
> > > create data loss.
> > >
> > > If you don't store all information also in ILL request attributes it will be
> > > hard to determine what has been ordered for making acq decisions and
> > > creating reports.
> > >
> > > Also: there already was as specific bug for this change, stuck in discussion
> > > for these reasons: bug 21983
> >
> > I'd have loved to at least get a comment/reaction. The fix mentioned seems
> > to be to enforce the change I marked as critical.
>
> Also, if you really want to do this, because it needs to be done: what's
> with the old ill_requests? It caused bug 33873.
Should we do the same we did for orderlines?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:16:40 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:16:40 +0000
Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no
longer exists causes table to not render
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873
--- Comment #8 from Katrin Fischer ---
I vote for removing the FK again OR cleaning up the old ill_requests... either
this data should not exist or it should.
I vote for: it should exist and remove FK. And we could show the number not
linked when there is no record in the table.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:19:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:19:13 +0000
Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no
longer exists causes table to not render
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=21983
--- Comment #9 from Katrin Fischer ---
Please also see bug 21983.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:19:13 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:19:13 +0000
Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's
link to it - missing foreign key
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=33873
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:22:39 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:22:39 +0000
Subject: [Koha-bugs] [Bug 22440] Improve ILL page performance by moving to
server side filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
--- Comment #25 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #24)
> (In reply to Katrin Fischer from comment #23)
> > (In reply to Katrin Fischer from comment #22)
> > > (In reply to Katrin Fischer from comment #19)
> > > > Hm, I am not so happy about the FK change hidden/sneaked in with this bug.
> > > > Especially since it's now without documentation/warning to users and can
> > > > create data loss.
> > > >
> > > > If you don't store all information also in ILL request attributes it will be
> > > > hard to determine what has been ordered for making acq decisions and
> > > > creating reports.
> > > >
> > > > Also: there already was as specific bug for this change, stuck in discussion
> > > > for these reasons: bug 21983
> > >
> > > I'd have loved to at least get a comment/reaction. The fix mentioned seems
> > > to be to enforce the change I marked as critical.
> >
> > Also, if you really want to do this, because it needs to be done: what's
> > with the old ill_requests? It caused bug 33873.
>
> Should we do the same we did for orderlines?
A database table has the option to use COALESCE, so that might be an option. We
could also then shift the existing data.
I am not sure what the technical requirement for the FK was, so can't tell if
removing it again might be a valid option.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:35:33 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 15:35:33 +0000
Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no
longer exists causes table to not render
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873
--- Comment #10 from Pedro Amorim ---
(In reply to Katrin Fischer from comment #8)
> I vote for removing the FK again OR cleaning up the old ill_requests...
> either this data should not exist or it should.
>
> I vote for: it should exist and remove FK. And we could show the number not
> linked when there is no record in the table.
I don't see any issue with that, but again would like Martin and Tomas to chip
in.
However, the fix provided here in this bug (33873) is required, regardless of
whatever decision we go down with regarding the FK.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 18:03:41 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 16:03:41 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Sam Lau changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 18:03:45 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 16:03:45 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Sam Lau changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151900|0 |1
is obsolete| |
--- Comment #180 from Sam Lau ---
Created attachment 151937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151937&action=edit
Bug 17499: Add Koha-objects for messaging preferences
This patch adds Koha-objects for messaging preferences.
Adds simple validation for messaging preferences.
The validation includes
- throw exception if both borrowernumber or categorycode is given for a new
pref
- throw exception if patron for the given borrowernumber is not found
- throw exception if category for the given categorycode is not found
- throw exception if days in advance cannot be configured but is given
- throw exception if days in advance configuration is invalid (value between
0-30)
- throw exception if digest is not available but attempted to set on
- throw exception if digest must be enabled but attempted to set off
- throw exception on duplicate messaging preference
Adds a method for getting available messaging options.
Adds a method for setting default messaging preferenes.
$patron->set_default_messaging_preferences (where $patron is a Koha::Patron)
...or...
Koha::Patron::Message::Preference->new_from_default({
borrowernumber => 123,
categorycode => "ABC",
message_attribute_id => 1,
});
Since messaging preference is a feature that has multiple related database
tables,
usage via Koha-objects is sometimes frustrating. This patch adds easy access to
message transport types via
$preference->message_transport_types (for
getting)
$preference->set({ message_transport_types => ['email', 'sms'] }) (for
setting)
(also supports other calling conventions, see documentation for more)
Adds optional parameter message_name for
Koha::Patron::Message::Preferences->find
and ->search. Simplifies the Koha-object usage by allowing developer to skip
joins
and / or querying the message name via attribute_id from message_attributes
table.
Includes test coverage for basic usage.
To test:
1. prove t/db_dependent/Koha/Patron/Message/*
Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging
with these new Koha-objects.
Signed-off-by: Dominic Pichette
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Michal Denar
Signed-off-by: Sam Lau
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 18:03:48 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 16:03:48 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Sam Lau changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151901|0 |1
is obsolete| |
--- Comment #181 from Sam Lau ---
Created attachment 151938
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151938&action=edit
Bug 17499: Define koha_object(s)_class where needed
This patch adds koha_object(s)_class for needed modules
to fix issues with tests.
Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Michal Denar
Signed-off-by: Sam Lau
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 18:03:52 2023
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jun 2023 16:03:52 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Sam Lau changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #151902|0 |1
is obsolete| |
--- Comment #182 from Sam Lau |