[Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #18)
> (In reply to Marcel de Rooy from comment #16)
> > (In reply to Marcel de Rooy from comment #15)
> > 
> > >     #   Failed test 'Screen message includes related fines total'
> > >     #   at t/db_dependent/SIP/Patron.t line 331.
> > >     #                   'Greetings from Koha. Og_K_qe88A -- Patron blocked
> > > by fines (11.11) on guaranteed accounts -- Patron owes 11.00'
> > >     #     doesn't match '(?^u:Patron blocked by fines \(22\.22\) on
> > > guaranteed accounts)'
> > 
> > If I debug on $patron->account->lines, I only see that 11 euro.
> > Do you miss a few assumptions in the mocking or so still?
> 
> Yes, not setting the type meant it was randomly a type that was counted in
> non-issues-charges or not. Should be fixed now

Great. One randomly failing test less.

-- 
You are receiving this mail because:
You are watching all bug changes.