[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Nick Clemens from comment #18)
> * Filters are operating on codes not values, 'FPL' works in 'Home library'
> but 'Fairview' doesn't

Yes, we should add dropdown lists for itemtype and libraries, like we do on the
patron search.
But for instance "home library" contains the location as well, that's not that
easy :-/

> * Location appears in 'Home library' column, but cannot be filtered on code
> or value

See above.

> * Status column not filterable or sortable

Yes, that's no longer possible, and won't be possible, at least in a first
iteration. That's not trivial it seems.

See the following commit:
    Bug 33568: Status

    FIXME We need tests here!

    See the FIXME in the code, we are losing the ability to search on the
status,
    but this is really impossible to implement if we are not storing the
    status (DB or search engine).

> * Date columns filters only work on SQL formats '2023-06-01' works
> '06/01/2023' doesn't

I thought I fixed that earlier somewhere else. And I did, on
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145096
But that's not nice. Not considering this high priority for now and considering
outside the scope of this bug.

> * Click 'show filters', 'hide filters' and repeat X 2 - status column
> disappears?

See the following commit:
    Bug 33568: Restore filters

    FIXME - If we click 'show filters' the 'columns' list does not contain
    all the columns.
    We are destroying the DT and the hidden columns are removed from the
    dom.

    I think there are 2 possible solutions here:
    1. don't destroy but adjust the 'dom' parameter of DT (I didn't manage
    to make this work correctly, because of the th filters)
    2. Move the th definition in the JS init of DT

> If you do choose to show all items, a sort action requires reloading the
> whole table - is it possible to sort/filter on the loaded data?

We could imagine a "freeze" button to remove the AJAX driven behaviour, if all
data are loaded. But the behaviour will then be different. It will help to
filter/sort on columns on which it's not possible server-side, but I am not
sure it's a good idea...


Remaining TODOs (in addition of the FIXMEs in the code):
* Display the library name of the patron "A patron from LIBRARY NAME" if the
patron's data must be hidden. This is related to bug 29523.

* Fix bug 33817

* Fix bug 33804

* Add dropdown lists for itemtype, libraries (current library and library) and
collection in the column filter row (like we do on the main patron search).
However how do we deal with "home library" which contains the location as well?

* Search by formatted date (see bug 32505)

-- 
You are receiving this mail because:
You are watching all bug changes.