[Koha-bugs] [Bug 31336] In-progress background jobs give incorrect progress message

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31336

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
I rise to major importance, this could lead to misunderstanding.

I see in template :
[% IF job.status != 'new' %][% PROCESS 'report' %][% END %]

https://git.koha-community.org/Koha-community/Koha/src/commit/9c565eff1357c2fdf900f006a17fa62fd4f2f9ee/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt#L99

Should we simply change for job.status finished, canceled or failed ?

Also :
I see some templates are managing the cancel status :

https://git.koha-community.org/Koha-community/Koha/src/commit/00e33f875808761e6a280778842fd28bd5ab27d9/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_biblio_record_modification.inc#L24

It is missing in batch biblio record deletion.

Maybe we should change includes to define "report_sucess", "report_canceled"
...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.