[Koha-bugs] [Bug 33933] Use restrictions appear twice for items on OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #2)
> It looks correct but I am not confident in signing it off. The code is
> confusing!

I agree the code is confusing. At some point, I think we need to move more of
this status information lower in the code, so that we're showing the same thing
via all controllers (e.g. detail page, API, ILS-DI, etc). 

> How did we miss that on bug 32611?

I think only the "Not for loan" was tested. Since "Not for loan" turns off
"Available", this regression wouldn't have appeared during testing. 

That said, bug 32611 says "The patch also adds another case for displaying the
item restricted status. Previously items.restricted would only display if the
item *also* had a notforloan value."

I don't think that's true, as I've been using use restrictions for quite a few
years, and they've shown up for "available" items. (Many of my libraries use
"Photocopy only" or "Electronic" use restrictions.)

-- 
You are receiving this mail because:
You are watching all bug changes.