[Koha-bugs] [Bug 33967] New: REMOTE_ADDR incorrect in plack.log when run behind a proxy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967

            Bug ID: 33967
           Summary: REMOTE_ADDR incorrect in plack.log when run behind a
                    proxy
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

As I note in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068#c54 the
Koha::Middleware::SetEnv breaks the flow of $env through the Plack middleware
wrapper chain.

This means that post-processing middleware that happen after
Koha::Middleware::SetEnv (e.g. Plack::Middleware::AccessLog) will use the wrong
$env variable (ie the $env variable that was being used before
Koha::Middleware::SetEnv was run in the pre-process middleware phase).

By retaining the original $env hashref in Koha::Middleware::SetEnv, we should
be able to preserve the referential integrity. 

Going to give a patch a go now...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.