[Koha-bugs] [Bug 33970] We need a "backend" column in "illrequestattributes" table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33970

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |jonathan.field at ptfs-europe.
                   |                            |com,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |oleonard at myacpl.org,
                   |                            |tomascohen at gmail.com

--- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Original issue is mentioned in bug 20640. Do a search for "Duplicate ID"

Don't apply patches. ILL set-up, run:
bash <(curl -s
https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)

The above will fetch the latest of FreeForm and BLDSS, that are already
compatible with this.

Test plan:
- Create a new BLDSS request, enter "9780822370451" on "Keywords" input field
- Put "42" on cardnumber and pick a branch, submit
- Next screen, on the far right of the table, click the "Request <BLLID>" link
- Next screen, click the "Request" bottom button
- Next screen, click the "Switch provider" button and pick "FreeForm"
- Verify you have a "Duplicate ID" error, the logs say
- Duplicate entry '2-author' for key 'PRIMARY'

This is because both backends have a "author" illrequestattribute field.
And switching provider maintains the same ILL request (thus illrequest_id).
It's trying to add another row with composite key "1-author" in the
illrequestattributes table.

Apply patches, and either reset_all or updatedatabase.pl
Do the test plan again, verify it now succeeds.

This should also cover the use-case where different backends have different
meaning for equal attribute keys.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.