[Koha-bugs] [Bug 33992] New: Only consider the date when labelling a waiting recall as problematic

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992

            Bug ID: 33992
           Summary: Only consider the date when labelling a waiting recall
                    as problematic
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The recalls awaiting pickup report has two tabs - recalls waiting, and recalls
waiting over X days. This number of days when a recall is labelled
'problematic' is defined by the RecallsMaxPickUpDelay system preference.

Sometimes recalls do not show here even when we would expect them to. This is
because the waiting_date for recalls is a timestamp, and Koha wrongly considers
the time when deciding if the recall has been waiting for a problematic number
of days.

For example, consider this set up:

- RecallsMaxPickUpDelay = 1 day
- Recall has been waiting since 12 June
- Today is 13 June

Treating 12 June as 1 day, the recall has been awaiting pickup for more than 1
day, so I would expect it to show under the 'recalls waiting over X days' tab.

It doesn't, because when we look at the database timestamps:

- Recall has been waiting since 2023-06-12 19:06:58
- Time now is 2023-06-13 17:06:58
- Recall waiting_date plus 1 max pickup delay day equals 2023-06-13 19:06:58 -
which is 2 hours after the cut off to be considered problematic.

Koha should not consider the timestamp in this case, it should only look at the
date

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.