[Koha-bugs] [Bug 33887] Automatic checkin should be able to optionally fill the next hold with the returned item

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33887

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #8 from David Nind <david at davidnind.com> ---
Hi Sam.

I've Failed QA as there is an error with the database update. This is the
message I get:

kohadev-koha at kohadevbox:koha(bz33887)$ updatedatabase
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_33887.pl  [21:35:55]:
Bug 33887 - Automatically fill the next hold with a automatic check in.
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error
in your SQL syntax; check the manual that corresponds to your MariaDB server
version for the right syntax to use near '' at line 1 at
/kohadevbox/koha/C4/Installer.pm line 741

This is because there is a missing closing bracket in the do statement: ....,
'YesNo'}); - this should be ...., 'YesNo') });

I manually fixed this and followed through the test plan - everything works as
per the test plan. So happy to sign it off once that is fixed.

Some other feedback:

- For the AutomaticCheckinAutoFill system preference:
  . Make the dropdown options Don't allow/Allow: "we" spent a bit of time on a
previous release making these more consistent across all system preferences.
  . I think for the note, that it should start with "This system preference",
instead of "These system preferences".

- Item type description:
  . I think the label should be "Automatic check-in", as it is a noun (I
think). See the terminology guidelines
https://wiki.koha-community.org/wiki/Terminology#C
  . Also, if this requires the AutomaticCheckinAutoFill to work, then I think
we should include that in the guidance, including linking to the system
preference. For example:
    If checked, items are automatically checked in once they've reached their
due date. This requires setting the AutomaticCheckinAutoFill system preference
and scheduling the running of the misc/cronjobs/automatic_checkin.pl cronjob.

Also, thank you for the awesome work on all the sign-offs that you have been
doing!

David

-- 
You are receiving this mail because:
You are watching all bug changes.