[Koha-bugs] [Bug 33987] Combine multiple db updates in C4::ImportBatch::BatchCommitRecords for efficiency/avoiding possible deadlocks

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33987

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 152297
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152297
Bug 33987 - Combine multiple db updates one in BatchCommitRecords

Review of attachment 152297:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33987&attachment=152297)
-----------------------------------------------------------------

::: C4/ImportBatch.pm
@@ +682,5 @@
>                  $query = "UPDATE import_auths SET matched_authid = ? WHERE import_record_id = ?";
>              }
> +            # Combine xml update, SetImportRecordOverlayStatus, and SetImportRecordStatus updates into a single update for efficiency, especially in a transaction
> +            my $sth = $dbh->prepare_cached("UPDATE import_records SET marcxml_old = ?, status = ?, overlay_status = ? WHERE import_record_id = ?");
> +            $sth->execute($oldxml, 'imported', 'match_applied',, $rowref->{'import_record_id'});

Is there a typo on this line? I see two commas in a row?

-- 
You are receiving this mail because:
You are watching all bug changes.