[Koha-bugs] [Bug 33971] Remove support for x-koha-query header

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33971

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #9)
> (In reply to Martin Renvoize from comment #8)
> > https://git.koha-community.org/Koha-community/Koha/src/branch/master/api/v1/
> > swagger/swagger.yaml#L714 will also need cutting out ;-).
> > 
> > Generally this all looks good to me. What were Marcel's reasons for wanting
> > to keep it as an option?  I've used it in the past I believe, and it seemed
> > to work nicely, but I'm not against dropping it.. one less code path to
> > maintain.
> 
> See bug 32406 comment5 and bug 32401 comment9.
> In short, search terms in URL could be a privacy issue. Not allowing
> searching for UTF-8 in a multilingual system would be rather poor.
> But no blocker :)

I think we should remove it, and if someone wants to implement it right, just
do it properly on a new bug, in which we discuss the implementation details
(e.g. requiring base64 encoding, documentation, etc).

-- 
You are receiving this mail because:
You are watching all bug changes.