[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Updated test plan:

* Set CurrencyFormat to FR
* Enable UseRecalls
* Enable ArticleRequests
* Administration > circulation and fine rules
* Add a new rule:
  * Fine amount: 0.10
  * Fine charging interval: 1  
  * Overdue fines cap: 1.50
  * Recall overdue fine amount: 1.10
* Save rule
* Verify that both Overdue fines cap and recall overdue fine amount show 
  formatted with comma as: 1,50, 1,10
* Edit rule
  * Fine amount: 0.10 - OK!
  * Fine charging interval: 1  
  * Overdue fines cap: 1,50 - NOT OK!
  * Recall overdue fine amount: 1,10 - NOT OK!
* Save rule
* With SQL:

select * from circulation_rules where rule_name in
("fine","overduefinescap","recall_overdue_fine","article_request_fee");

+----+------------+--------------+----------+---------------------+------------+
| id | branchcode | categorycode | itemtype | rule_name           | rule_value
|
+----+------------+--------------+----------+---------------------+------------+
|  9 | NULL       | NULL         | NULL     | fine                | 0.10      
|
| 11 | NULL       | NULL         | NULL     | overduefinescap     | 1,50      
|
| 32 | NULL       | NULL         | NULL     | recall_overdue_fine | 1,10      
|
+----+------------+--------------+----------+---------------------+------------+

* Edit rule for Article request fee 
  * Fee: 1,0
* Verify it's also wrong in the database with above SQL.
--> This is already fixed by the patch set now, as we don't allow to edit the
rules and the pattern check works.

Missing bits and pieces:

Have to:
* When a rule is edited, the input field will be set to the display value
(1,00). I didn't find an "unformat" equivalent for JS. This now triggers the
pattern check, so you need to edit all values before being able to save them.
We could use the inputmode="decimal" on the input fields to select for
unformatting.
* Should we be able to deactivate overduefinescap by leaving it empty?
(Unlimited?)

Would be nice:
* It would be nice to provide more help in fixing wrong values or automatically
fixing obvious ones like xx,xx.

-- 
You are receiving this mail because:
You are watching all bug changes.