[Koha-bugs] [Bug 34051] New: Koha::AuthorisedValues->get_description_by_koha_field not caching results for non-existent values

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34051

            Bug ID: 34051
           Summary: Koha::AuthorisedValues->get_description_by_koha_field
                    not caching results for non-existent values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

As I note at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216#c5
Koha::AuthorisedValues->get_description_by_koha_field isn't caching database
results for non-existent values.

Many authorised values lists don't have a value for 0, but many records contain
values of 0. 

Koha::AuthorisedValues->get_description_by_koha_field() will do a database call
every time it encounters a value that doesn't exist in the AV table, because it
isn't caching the empty/null that is calculated based on the incoming value not
existing in the AV table.

In terms of code, it is a simple change, but
Koha::AuthorisedValues->get_description_by_koha_field is used in a lot of
places, so obviously we'll want to be careful making any changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.