[Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 21 21:25:15 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 152540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152540&action=edit
Bug 33169: Add support for FA styles

Font awesome now provides a different approach to icon styles so you can
specify things like:

```
<i class="fa fa-camera-retro"></i>
```

but also

```
<i class="fa-solid fa-camera-retro"></i>
```

The original implementation had a hardcoded `fa` and having an extra
parameter for the *style* seemed overkill, as we would need to handle
even a list of styles like on this example:

```
<i class="fa-sharp fa-solid fa-camera-retro"></i>
```

So I chose to just explicitly require the full FA icon class and pass it
thru. With no manipulation on the Vue side.

This patch does that, and adjusts the 'style' for some icons, as
introduced by the FA v6 patchset.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list