[Koha-bugs] [Bug 31393] Koha::Config->read_from_file incorrectly parses elements with 1 attribute named" content" (Shibboleth config)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31393

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
(In reply to Julian Maurice from comment #9)
> Hi David,
> 
> Have you checked that the 'content' key is not used anywhere else ?

(In reply to David Cook from comment #8)
> Hopefully this patch doesn't break a case where there really is a config
> item that only has an attribute of "content" that should be treated as if it
> didn't have an attribute.

Not really. That's why I said hopefully ;). 

I did briefly look at fonts but didn't really look into it deeply.

(In reply to Julian Maurice from comment #10)
> It looks like it's used in C4::Creators::PDF::Font

That's interesting. 

It does look like this change would break that:

                        'ttf' => {
                                   'font' => [
                                               {
                                                 'type' => 'TR',
                                                 '_content' =>
'/usr/share/fonts/truetype/dejavu/DejaVuSerif.ttf'
                                               },

-- 
You are receiving this mail because:
You are watching all bug changes.