[Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152339|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 152613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152613&action=edit
Bug 33847: Database update replaces undefined rules with defaults rather than
the value that would be used

Bug 29012 introduces a database update that sets the default values for rules
that are required but undefined. This functionally changes the results of the
circulation rules.

Instead, this update should find value that is being used for that rule combo
and use that as the rule value, only using the default in the case that the
derived rule doesn't exist or has a null value.

Test Plan:
1) Check out Koha 22.05.05
2) Create a default all/all/all rule, 3 other rules. Ensure they all have Loan
period set to 7, with one of the non-default rules having a Loan period of 14.
3) Delete all but one of the non-default rules with the following query:
   Delete from circulation_rules where rule_name  = 'issuelength' and (
rule_value != 14 and not ( branchcode is null and categorycode is null and
itemtype is null ) ) limit 2;
4) Check out 254f721320
5) Run updatedatabase.pl and restart
6) Note the rules were recreated with the value 0
7) Repeat steps 1-4
8) Apply this patch
9) If you're using the same database, set the version to 22.0600023 and restart
10) Run updatedatabase.pl
11) Note the rules were recreated, but the value is the derived value from the
all/all/all rule!

Signed-off-by: Kevin Carnes <kevin.carnes at ub.lu.se>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.