[Koha-bugs] [Bug 34112] Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 23 19:32:20 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34112

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #152639|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 152652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152652&action=edit
Bug 34112: Replace fa.fa-pencil-alt with fa-solid.fa-pencil in edit buttons

The FontAwesome class "fa-pencil-alt" works in v.6 but is actually a v.5
class. We should use "fa-solid fa-pencil" instead.

This patch also corrects some leftover instances of "fa-edit"

To test, apply the patch and view some pages in the OPAC and staff
interface which have updated icons, e.g.

 - Administration -> Libraries
 - Catalog -> Bibliographic details
 - OPAC -> Bibliographic details

Confirm that the pencil icon looks correct. Checking all modified
templates is probably too much, but inspecting the patch should show
that only fa-pencil-alt and fa-edit icons are affected.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list