[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083

Philip Orr <philip.orr at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philip.orr at lmscloud.de

--- Comment #15 from Philip Orr <philip.orr at lmscloud.de> ---
First thing I tested was to create a new borrower attribute with the name
"School class" with nothing checked (so not repeatable), also not linked to any
authorized values.
It showed up in patron batch modification and worked correctly, the patrons I
batch modified had the value I
specified ("3a") added to their attribute.

Then I tried setting the borrower attribute to repeatable. It still shows up in
patron modification, so that's good.
I tried setting a new value for the same patrons ("4b"). The old value "3a" was
overwritten by the new value "4b", so that worked correctly.
Then I manually gave each patron 3 separate values for the "School class"
attribute, "3a", "4b" and "5c".
Then I went back to patron modification and used batch patron modification to
give them a new value "6d".
This resulted in all of the previous values being deleted and instead the new
value was saved.
So instead of having three separate "School class" attributes, they now only
had one with the value "6d".
So that worked correctly as well.
I then tried giving the patrons multiple "School class" values in the same
batch patron modification and that worked as expected too: the old value "6d"
was deleted and the multiple new values "3a", "6y" and "12b" were created for
each patron.

Then I thought it might be a good idea to test if I could change multiple
different borrower attributes in the same
batch patron modification. Unfortunately that doesn't work very well, as soon
as one the borrower attributes is connected to an authorized value (in this
case our usual attribute "Show barcode" connected to the authorized value
YES_NO) then in batch patron modification all the text entry fields for all
borrower attributes are changed to authorized value drop down fields. So I
couldn't edit "School class" and "Show barcode" at the same time in batch
patron modification. I don't know if that's already an existing bug or if I
should make a new bug for that.

Anyway besides that everything works as expected. Only the currently saved
borrower attributes "3a", "6y" and "12b" are found in borrower_attributes:
SELECT * FROM borrower_attributes
id      borrowernumber  code    attribute
38      47                              CLASS   3a
39      47                              CLASS   6y
40      47                              CLASS   12b
41      18                              CLASS   3a
42      18                              CLASS   6y
43      18                              CLASS   12b
44      12                              CLASS   3a
45      12                              CLASS   6y
46      12                              CLASS   12b
47      16                              CLASS   3a
48      16                              CLASS   6y
49      16                              CLASS   12b

-- 
You are receiving this mail because:
You are watching all bug changes.