[Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK... with that last patch I think we should be working correctly in all
cases..

Please follow the test plan in comment 25 to confirm this.

We can drop/squash half the patches here.. the bug has become a real mess with
things getting added then reverted, then added and finally reverted again.

I'm not sure we need the js unformat function I created at all at this point..
it's no longer used here.. but might be helpful migrated to another bug in case
anyone needs it elsewhere.  I'm also not sure about the location of the
unformat call deep down in Circulation rules.. it feels like we should perhaps
be calling this higher up in the controller rather than the module expecting
different input types based on configuration.

Anyway.. I'd love to see this move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.