[Koha-bugs] [Bug 34128] Series entry in the 490 field causes the ordering of items to change in the holdings table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34128

--- Comment #5 from Phil Ringnalda <phil at chetcolibrary.org> ---
Amusingly, there's also is_serial, which CheckPrevCheckout added because it
wanted to know about actual serials where you don't want to warn someone
checking out the current issue of People that they checked out the issue from
last week, and the issue from the week before, and so on.

Alas, it says something is_serial if biblio->serial, or if leader/07 is "s",
rather than only checking the leader (which is also bad for it, since for
people who actually have 490 mapped to seriestitle, and thus set serial for it,
people who have forgotten that they already read number 34 in a series won't be
warned about that). Maybe we need to add really_is_serial?

Or for that matter, really_really_is_serial, since what this code actually
needs to know is whether or not sorting by serialid.publisheddate makes sense,
which it only does if all, or maybe at least two, of the itemnumbers exist in
serialitems.itemnumber. I have plenty of biblios with leader/07="s", but since
I don't use the serials module, serialid.publisheddate doesn't do anything for
me. Or I guess in a less painful way to look up for every load of every items
table, if the biblionumber exists in a serial.biblionumber.

-- 
You are receiving this mail because:
You are watching all bug changes.