[Koha-bugs] [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Pedro Amorim from comment #22)
> (In reply to Marcel de Rooy from comment #21)
> > Created attachment 152885 [details] [review] [review]
> > Bug 34092: (QA follow-up) Typo and removing unneeded spread
> > 
> > Typo patron_searh_js.
> > The spread is not needed; the function checks for defined later.
> > 
> > Note for QA/RM: Ignore this qa tools warning:
> >     forbidden pattern: console.log (line 211)
> > This is an intended console warning.
> > 
> > Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
> 
> Hi Marcel, thank you so much for QA! =D
> 
> With your removal of spread, clicking the "add patron" button on
> /cgi-bin/koha/patroncards/edit-batch.pl results in a search error and errors
> in the console.
> 
> Test this on a clean k-t-d please, without having any searchable patron
> attribute types in the system.

Will have a look soon. Not intended :)

-- 
You are receiving this mail because:
You are watching all bug changes.