[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Some observations:
It is very good to add the parameter. That will make people more comfortable.
But you check twice and the first time without.
Could we remove the first check? And just depend on the last one (that has the
parameter test)? The time between those two checks will be limited.

After we did ++$counted; you still do a next in the second check, should we
decrement counted again? Minor thing, bit picky..

-- 
You are receiving this mail because:
You are watching all bug changes.