[Koha-bugs] [Bug 33270] OAI-PMH should not die on record errors

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33270

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Revisiting.
This code part somehow does not look good to me in OAI::Server::ListBase:

                if ($marcxml) {
                    $self->record(
                        Koha::OAI::Server::Record->new(
                            $repository, $marcxml, $timestamp, \@setSpecs,
                            %params
                        )
                    );
                } else {
                    $self->record(
                        Koha::OAI::Server::DeletedRecord->new(
                            $timestamp, \@setSpecs, identifier =>
$repository->{koha_identifier} . ':' . $biblionumber
                        )
                    );

If there is no marcxml, you now decide that it is a DeletedRecord. But I would
assume that you should just test $deleted? It could be a normal record, but
also crashing on the strip_nonxml route.
Please clarify.

Do we need additional tests in the db_dependent OAI scripts btw?

-- 
You are receiving this mail because:
You are watching all bug changes.