[Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 152913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152913&action=edit
Bug 34178: Cache ItemsAnyAvailableAndNotRestricted in memory and don't
precalculate

There are several places in the code where we precalculate
ItemsAnyAvailableAndNotRestricted to avoid
looping on this routine when calling IsAvailableForItemLevelRequest on a list
of items form a biblio

The value of ItemsAnyAvailableAndNotRestricted is only used when there is a
circulation rule for
'onshelfholds' with a value of '2' (If all unavailable)

Rather than calculate a value that may never be used, let's cache this value
per request when we do
calculate it - and reuse the cached value

To test:
 1 - Apply patch
 2 - Set circulation rule 'On shelf holds allowed' as 'If all unavailable'
    make sure the rule applies to all of the items/patrons you test with
 3 - Find a record with two items that are available
 4 - Try to place a hold for a patron - not allowed
 5 - Check out one item to another patron
 6 - Attempt hold - still not allowed
 7 - Check out second item to another patron
 8 - Attempt hold - allowed!
 9 - Apply patch
10 - Cancel and replace hold - it is allowed!
11 - Check in one item, and cancel hold
12 - Place hold - not allowed!
13 - Check in second item
14 - Place hold - not allowed!
15 - prove -v t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.