[Koha-bugs] [Bug 32613] Can we add 'autocompletion' to our SQL reports editor?

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 2 12:05:27 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613

Jacob O'Mara <jacob.omara at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> ---
Hi Lucas,
I can remove INSERT, DELETE etc. from the sql.js keywords. This would also
remove the syntax highlighting for these in the codemirror instance but that
should not be an issue as they should not be being used anyway.

In terms of column autocompletion the columns only appear when referencing the
column in the format 'table.column' eg:

SELECT alert.alertid FROM alert; 

would give you autocompletion for the column. While this is more typing than is
typical it does reduce the likelihood of an end user requesting an incorrect
column. I'm open to suggestions as I can modify the parsing to always show all
options if that is deemed better. (should have been written above so apologies)
additionally, I very stupidly added the . key to the list of exception keys
which will be amended in a patch I will upload later. Taking this off of 'needs
signoff' in the meantime

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list