[Koha-bugs] [Bug 33028] The decimal separator 'comma' and its consequences on the calculation of fines (crons)

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 3 12:12:33 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 147058
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147058
Bug 33028: Fix calculations around cronjob fines.pl

Review of attachment 147058:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33028&attachment=147058)
-----------------------------------------------------------------

:::
installer/data/mysql/atomicupdate/fix_calc_fines_fr-currency_21-11-MT39815.pl
@@ +40,5 @@
> +                                $rule_id, $rule_value
> +                            )
> +                        );
> +                    }
> +                }

We need some additional handling here for the .00/,00 case.. in particular
0.00/0,00

Perl will treat 0.00 as a string for truthyness and thus we need to reduce to
just the integer 0 in this case.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list