[Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
In general I think we should stick with the well tested behavior from
opac/intranet requests and make sure that the APIs use the same logic. So if we
already had the stricter behavior in GUI, I think that's usually the right
choice.

In your documentation, there is one inconsistency:

Call in ILSDI/Services.pm
HoldItem - would have allowed placing holds on damaged/notforloan/etc items

Call in ILSDI/Services.pm:
GetServices - Already a combination of CanItemBeReserved and
IsAvailableForItemLevelRequest


I believe you caused an unwanted change in behaviour, negative nfl-values are
in fact holdable, but won't be no longer with the change:

-        $item->notforloan > 0  || # item with negative or zero notforloan
value is holdable

vs. 

+    return { status => 'notforloan' } if ( $item->notforloan ||
$notforloan_per_itemtype );


I haven't had time to look at the methods at a whole, but do we really want to
remove the checks from IsAvailableForItemLevelRequest?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.