[Koha-bugs] [Bug 32684] Implement SIP patron status field "too many items lost"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32684

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The $server param addition looks good for the case at hand, but we still have
some calls in ILS.pm that do not have it now. Could be a potential cause for
confusion in the future..

# git grep "ILS::Patron\->new"
[OK] ILS.pm:    return C4::SIP::ILS::Patron->new(@_);
[checkout] ILS.pm:    $circ->patron( $patron =
C4::SIP::ILS::Patron->new($patron_id) );
[checkin] ILS.pm:        $circ->patron( $patron = C4::SIP::ILS::Patron->new( {
borrowernumber => $item->{borrowernumber} } ) );
[pay_fee] ILS.pm:    $trans->patron($patron =
C4::SIP::ILS::Patron->new($patron_id));
[add_hold] ILS.pm:    $patron = C4::SIP::ILS::Patron->new( $patron_id );
[cancel_hold] ILS.pm:    $patron = C4::SIP::ILS::Patron->new( $patron_id );
[alter_hold] ILS.pm:    $patron = C4::SIP::ILS::Patron->new( $patron_id );
[renew] ILS.pm:    $trans->patron($patron = C4::SIP::ILS::Patron->new(
$patron_id ));
[renew_all] ILS.pm:    $trans->patron($patron = C4::SIP::ILS::Patron->new(
$patron_id ));

Apart from that, this statement will produce a warning:
+    if ( my $lost_block_checkout = $server->{account}->{lost_block_checkout} )
{

Let me submit a simple counter proposal creating an method for it.

-- 
You are receiving this mail because:
You are watching all bug changes.