[Koha-bugs] [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 9 16:38:10 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159

--- Comment #11 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to Nick Clemens from comment #5)
> Created attachment 147970 [details] [review]
> Bug 33159: Simplify ES handling and fix zebra handling
> 
> Before this patch we used two indexes for the thesaurus values, we can
> simply index both needed fields into a single index and just form the
> search correctly.
> 
> This patch also ensures we pass the 'thesaurus' vlaue for the heading
> directly to the query builder - for zebra it goes through, and for ES
> we convert it to the expected code.
> 
> This patch also moves the necessary mappings out of the user definable
> mappings and hardcodes them. There is precedent for this with
> 'match-heading', it ensures matching works as expected
> 
> To test:
> 1 - Follow previous test plan in Zebra and ES

It seems to work with Zebra now. But for ES, after resetting the mappings and
re-index (recreating) the indexes, linking doesn't work anymore. I notices that
both Subject-heading-thesaurus and Subject-heading-thesaurus-conventions index
was removed from mappings.yaml. Was that a mistake? I thought you want want a
single index for both 008/_11 and 040f like Janusz did?

I added these lines to the mappings file:

@@ -805,6 +805,20 @@ authorities:
         sort: ~
         suggestible: ''
     type: ''
+  Subject-heading-thesaurus:
+    label: Subject-heading-thesaurus
+    mappings:
+      - facet: ''
+        marc_field: 008_/11
+        marc_type: marc21
+        sort: ~
+        suggestible: ''
+      - facet: ''
+        marc_field: 040f
+        marc_type: marc21
+        sort: ~
+        suggestible: ''
+    type: thesaurus
   authtype:
     label: authtype
     mappings:

After resetting the mappings and re-index, linking works again in ES.

Regards,
Frank

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list