[Koha-bugs] [Bug 33205] New: (Bug 28268 follow-up) Method call inside quotes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33205

            Bug ID: 33205
           Summary: (Bug 28268 follow-up) Method call inside quotes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: januszop at gmail.com
                CC: ere.maijala at helsinki.fi

Bug 28268, in Koha::MetadataRecord::Authority::get_all_authorities_iterator,
introduced a warning:

warn "Something went wrong reading record for authority $row->authid: $@\n";

But a method cannot be called from within quotes in Perl - extrapolation does
not work for functions/methods.  So, if something really goes wrong, this line
of code produces a warning like:

Something went wrong reading record for authority
Koha::Schema::Result::AuthHeader=HASH(0x55cf7e0d0958)->authid: Empty String at
/usr/share/perl5/MARC/File/XML.pm line 450.

which is not very informative -- authid is missing.

Proposal: $row->authid should be placed outside of the quotes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.