[Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Mar 11 12:42:35 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Adam, 

your new file looks like a patch should, thanks!

Some things to note:

1) The older file that was uploaded as 'patch' would have confused our scripts
so I have obsoleted and only left your new file. This will make things work
with sandboxes and git bz for others.

2) I notice that you code is not using any identation. We use 4 spaces for
indentation and it should fit in its spot with the rest of the code. 

3) Sponsored-by: N/A is not needed and would show as N/A in release notes, but
we can delete this in a later step. You could list your institution as sponsor
if you want :)

We currently have a big backlog of patches and we rely on volunteers for
testing and QA'ing code, so it might take a little while to get feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list