[Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Mar 13 14:24:43 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The preferece is used in only one routine, Koha::Patron->notice_email_address. 
But it appears at some point, this method pretty much supplanted
Koha::Patron->first_valid_email_address and is used in a lot more of the
codebase.

notice_email_address is used in:

C4::Auth_With_shibboleth
C4::Letters (as the default)
C4::Auth - For 2FA
C4::Auth_with_ldap
C4::Reserves
shareshelf.pl
memberentry.pl
opac-registration-varify.pl
two_factor_auth.pl
notice.pl
memberentry.pl
pendingreserves.pl
Koha::Ticket
Patron::Import.pm
suggestion.pl
overdue_notices.pl
TalkingTech_iteive_outbound.pl
notice_unprocessed_suggestions.pm

first_valid_email is now only used in:

clubs-tab.tt
waiting_holds.inc
transferstoreceive.tt
opac-sendbasket.pl
Koha::SharedContent

And there's likely a few other cases where we refer more directly to the email
fields rather than using the methods.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list