[Koha-bugs] [Bug 33210] New: (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210

            Bug ID: 33210
           Summary: (Bug 31963 follow-up) No hold fee message on OPAC
                    should be displayed when there is no fee
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P3
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: januszop at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: aleisha at catalyst.net.nz, gmcharlt at gmail.com

After resolving Bug 31963 everything works as expected when there is hold fee
defined (!= 0).  But in case when the fee for given patron category is set to
0.00, the user will always see the message "You will be charged a hold fee of
0,00 ...", which is obviously not intended.

This is because categories.reservefee is returned from database as '0.000000'
and as such, without type casting, is interpreted as string in Perl. Prior to
Bug 31963 the result was compared to 0 before sending anything to the template,
so the casting was done, now it is not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.