[Koha-bugs] [Bug 33223] New: Koha::Patron->notice_email_address isn't consistently used

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223

            Bug ID: 33223
           Summary: Koha::Patron->notice_email_address isn't consistently
                    used
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 18398, 33192

As highlighted in bug 33192, we're not consistently using the
Koha::Patron->notice_email_address method to get our 'to' address for notices.

This bug serves to catch the last remaining cases where it's not being used and
should be.

Copying the list from the above bug, notice_email_address is used in:

C4::Auth_With_shibboleth
C4::Letters (as the default)
C4::Auth - For 2FA
C4::Auth_with_ldap
C4::Reserves
shareshelf.pl
memberentry.pl
opac-registration-varify.pl
two_factor_auth.pl
notice.pl
memberentry.pl
pendingreserves.pl
Koha::Ticket
Patron::Import.pm
suggestion.pl
overdue_notices.pl
TalkingTech_iteive_outbound.pl
notice_unprocessed_suggestions.pm

first_valid_email is used in:

clubs-tab.tt
waiting_holds.inc
transferstoreceive.tt
opac-sendbasket.pl
Koha::SharedContent


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398
[Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but
first valid e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192
[Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary'
for clarification
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.