[Koha-bugs] [Bug 23415] Notify patron fines when renewing

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #54 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described; it shows for me as FineNoRenewals.  I've signed off because
all of the functionality is fine. 

There were a couple of formatting issues around the currency in the pop-up box: 

1)  The trailing full stop / period feels a bit odd when it's currency:
Shows:  The patron has a debt of 3.21.
Perhaps:  The patron has a debt of 3.21

2)  If it's a round number, then pennies/cents aren't shown - it looks a bit
odd:
Shows:  The patron has a debt of 3.
Perhaps:  The patron has a debt of 3.00

3)  Is there any scope for adding the appropriate currency symbol?
Shows:  The patron has a debt of 3.21
Perhaps:  The patron has a debt of £3.21
And:  The patron has a debt of $3.21
And:  The patron has a debt of €3.21 

The other query was system preferences.

OPACFineNoRenewals has been renamed to FineNoRenewals.
There are two other system preferences:  OPACFineNoRenewalsBlockAutoRenew and
OPACFineNoRenewalsIncludeCredits

The descriptions (values) of these have been updated by this bug to refer to
FineNoRenewals, but should we also consider renaming the system preferences
themselves to:  FineNoRenewalsBlockAutoRenew and  FineNoRenewalsIncludeCredits
?  

I realise this last point might be out of scope of the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.