[Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, oleonard at myacpl.org

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is a great little enhancement, thanks Adam (and thanks for lending some
guidance here Matt too).

I have one very minor query, and I'm going to ask our resident UI guru to weigh
in on it.

The button placement and style is inline with the actions that take place on
the same page.  There's already precedents for that with the 'Go to item
search' which is also a link to another page.  I'm wondering if we aught to
distinguish more between 'Link to new page' and 'Actions on current page' here?
 We could make this 'feel' like an action by updating the text to 'View search
history', but that lengthens the button and I (and accessability guidelines)
tend to prefer less wordy links (I'd actually opt for dropping the 'Go to' in
the "Item search" button too).  Or perhaps we could distinguish these two
buttons somehow.. add a separator before them as a logical group.. or right
aligh these two.. or change the style up a bit?

Owen, do you have any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.